Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagemacro fix4 #4693

Merged
merged 6 commits into from May 4, 2021
Merged

Pagemacro fix4 #4693

merged 6 commits into from May 4, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 4, 2021

Part of fixing #3196. Mostly by linking to the original rather than transcluding. But also two case of simply removing the macro

@hamishwillee hamishwillee requested review from a team May 4, 2021 05:42
@hamishwillee hamishwillee requested a review from a team as a code owner May 4, 2021 05:42
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team May 4, 2021 05:42
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/Attribute/cursor
Title: cursor
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/SVG/Attribute
    • Can't resolve /en-US/docs/SVG/Content_type#FuncIRI
    • Can't resolve /en-US/docs/SVG/Content_type#FuncIRI
    • Can't resolve /en-US/docs/SVG/Element#Container_elements
    • Can't resolve /en-US/docs/SVG/Element#Graphics_elements

URL: /en-US/docs/Web/API/Window/ondeviceorientation
Title: Window.ondeviceorientation
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
    • /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
    • /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
    • /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
    • /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

External URLs

URL: /en-US/docs/Web/SVG/Attribute/class
Title: class
on GitHub


URL: /en-US/docs/Web/SVG/Attribute/cursor
Title: cursor
on GitHub


URL: /en-US/docs/Web/API/Window/ondeviceorientation
Title: Window.ondeviceorientation
on GitHub


URL: /en-US/docs/Tools/Web_Console/Helpers
Title: Web Console Helpers
on GitHub

No external URLs

URL: /en-US/docs/Tools/Web_Console/The_command_line_interpreter
Title: The JavaScript input interpreter
on GitHub

No external URLs

(this comment was updated 2021-05-04 05:48:24.861708)

(this comment was updated 2021-05-04 22:19:07.687616)

Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.
I guess, the macro error is not critical.
Thank you!

- Device Orientation
- Mobile
- Orientation
- Property
---
<p>{{ ApiRef() }}</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is giving me MacroPagesError for

  • globalcrypto (likely meant to point to /en-US/docs/Web/API/Crypto )
  • speechsynthesisgetter ( /en-US/docs/Web/API/SpeechSynthesis/getVoices maybe?)
  • windowmodal (Lacking the context. /en-US/docs/Web/API/Window/prompt ?)
  • onerroreventhandlerforwindow (Likely /en-US/docs/Web/API/GlobalEventHandlers/onerror )
  • chromewindow (the browser or the part of a web browser?)

Do you want to address them as part of this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to address them as part of this PR?

Thanks for spotting these. I'm pretty much fixing the easy flaws along the way, but mostly this is just about PageMacro. Upshot "No".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS These aren't in the page - they are in the sidebar. I do think we should look at them, but not in this.

@hamishwillee hamishwillee merged commit 8db916a into mdn:main May 4, 2021
@hamishwillee hamishwillee deleted the pagemacro_fix4 branch May 4, 2021 22:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants