Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ParentNode mixin docs #5057

Merged
merged 1 commit into from
May 17, 2021
Merged

Remove ParentNode mixin docs #5057

merged 1 commit into from
May 17, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented May 17, 2021

Interfaces implementing ParentNode (Document, DocumentFragment, Element) now document all ParentNode features directly without the ParentNode abstraction. This removes the remaining ParentNode pages:

https://developer.mozilla.org/en-US/docs/Web/API/ParentNode
https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/querySelectorAll

To double check, the following pages exist already:

https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelector

https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelectorAll
https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment/querySelectorAll
https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelectorAll

@Elchi3 Elchi3 requested review from a team as code owners May 17, 2021 11:33
@Elchi3 Elchi3 requested review from chrisdavidmills and removed request for a team May 17, 2021 11:33
@Elchi3 Elchi3 mentioned this pull request May 17, 2021
Closed
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/XPath
Title: XPath
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/Attribute_selectors
Title: Attribute selectors
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/attr redirects to /en-US/docs/Web/CSS/attr()

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub
Flaw count: 60

  • macros:
    • /en-US/docs/Web/API/DOMConfiguration does not exist
    • /en-US/docs/Web/API/DOMErrorHandler does not exist
    • /en-US/docs/Web/API/DOMImplementationList does not exist
    • /en-US/docs/Web/API/DOMImplementationRegistry does not exist
    • /en-US/docs/Web/API/DOMImplementationSource does not exist
    • and 55 more flaws omitted

URL: /en-US/docs/Web/API/Element/querySelectorAll
Title: Element.querySelectorAll()
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
    • /en-US/docs/Web/API/Div does not exist
    • /en-US/docs/Web/API/Iframe does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Code_snippets/QuerySelector

URL: /en-US/docs/Web/API/Element/querySelector
Title: Element.querySelector()
on GitHub
Flaw count: 4

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
    • /en-US/docs/Web/API/Div does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Code_snippets/QuerySelector

URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
    • /en-US/docs/Web/API/DocumentFragment/getElementById does not exist

URL: /en-US/docs/Web/API/DocumentFragment/querySelectorAll
Title: DocumentFragment.querySelectorAll()
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist

URL: /en-US/docs/Web/API/HTMLFormElement
Title: HTMLFormElement
on GitHub
Flaw count: 8

  • macros:
    • /en-US/docs/Web/API/HTMLFormElement/autocomplete does not exist
    • /en-US/docs/Web/API/HTMLFormElement/noValidate does not exist
    • /en-US/docs/Web/API/HTMLFormElement/checkValidity does not exist
    • /en-US/docs/Web/API/HTMLFormElement/requestAutocomplete does not exist
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 162

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • and 134 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/XUL_Overlays
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 17 more flaws omitted

URL: /en-US/docs/Web/API/Document/querySelectorAll
Title: Document.querySelectorAll()
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Code_snippets/QuerySelector

External URLs

URL: /en-US/docs/Web/XPath
Title: XPath
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Attribute_selectors
Title: Attribute selectors
on GitHub

URL: /en-US/docs/Web/CSS/:scope
Title: :scope
on GitHub

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub

URL: /en-US/docs/Web/API/Element/querySelectorAll
Title: Element.querySelectorAll()
on GitHub

URL: /en-US/docs/Web/API/Element/querySelector
Title: Element.querySelector()
on GitHub

URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/DocumentFragment/querySelectorAll
Title: DocumentFragment.querySelectorAll()
on GitHub

URL: /en-US/docs/Web/API/HTMLFormElement
Title: HTMLFormElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/querySelectorAll
Title: Document.querySelectorAll()
on GitHub

@rachelandrew rachelandrew mentioned this pull request May 17, 2021
Merged
chrisdavidmills
chrisdavidmills approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this look great; thanks @Elchi3 !

@chrisdavidmills chrisdavidmills merged commit 9ecfff4 into mdn:main May 17, 2021
@Elchi3 Elchi3 deleted the rm-parentNode branch May 17, 2021 14:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Elchi3 @chrisdavidmills