Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SVGURIReference #5111

Merged
merged 1 commit into from
May 19, 2021
Merged

Remove SVGURIReference #5111

merged 1 commit into from
May 19, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented May 19, 2021

BCD removal is in mdn/browser-compat-data#10522.

@foolip foolip requested review from a team as code owners May 19, 2021 09:25
@foolip foolip requested review from chrisdavidmills and removed request for a team May 19, 2021 09:25
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/SVGTRefElement
Title: SVGTRefElement
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/%3C/em%3ESVGTextPositioningElement%3Cem%3E does not exist
    • /en-US/docs/Web/API/%3C/em%3ESVGTextPositioningElement%3Cem%3E does not exist

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub
Flaw count: 61

  • macros:
    • /en-US/docs/Web/API/DOMConfiguration does not exist
    • /en-US/docs/Web/API/DOMErrorHandler does not exist
    • /en-US/docs/Web/API/DOMImplementationList does not exist
    • /en-US/docs/Web/API/DOMImplementationRegistry does not exist
    • /en-US/docs/Web/API/DOMImplementationSource does not exist
    • and 56 more flaws omitted

URL: /en-US/docs/Web/API/SVGGradientElement
Title: SVGGradientElement
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/SVGGradientElement/gradientUnits does not exist
    • /en-US/docs/Web/API/SVGGradientElement/gradientTransform does not exist
    • /en-US/docs/Web/API/SVGGradientElement/spreadMethod does not exist

URL: /en-US/docs/Web/API/SVGTextPathElement
Title: SVGTextPathElement
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/SVGTextPathElement/startOffset does not exist
    • /en-US/docs/Web/API/SVGTextPathElement/method does not exist
    • /en-US/docs/Web/API/SVGTextPathElement/spacing does not exist

URL: /en-US/docs/Web/API/SVGFEImageElement
Title: SVGFEImageElement
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGFEImageElement/preserveAspectRatio does not exist
    • /en-US/docs/Web/API/SVGFEImageElement/crossOrigin does not exist

URL: /en-US/docs/Web/API/SVGCursorElement
Title: SVGCursorElement
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGCursorElement/x does not exist
    • /en-US/docs/Web/API/SVGCursorElement/y does not exist

URL: /en-US/docs/Web/API/SVGPatternElement
Title: SVGPatternElement
on GitHub
Flaw count: 12

  • macros:
    • /en-us/docs/web/api/svgfittoviewbox (url: /en-US/docs/Web/API/SVGFitToViewBox) does not exist
    • /en-US/docs/Web/API/SVGFitToViewBox does not exist
    • /en-US/docs/Web/API/SVGPatternElement/patternUnits does not exist
    • /en-US/docs/Web/API/SVGPatternElement/patternContentUnits does not exist
    • /en-US/docs/Web/API/SVGPatternElement/patternTransform does not exist
    • and 7 more flaws omitted

URL: /en-US/docs/Web/API/SVGUseElement
Title: SVGUseElement
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/SVGUseElement/x does not exist
    • /en-US/docs/Web/API/SVGUseElement/y does not exist
    • /en-US/docs/Web/API/SVGUseElement/width does not exist
    • /en-US/docs/Web/API/SVGUseElement/height does not exist
    • /en-US/docs/Web/API/SVGUseElement/instanceRoot does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/SVGColorProfileElement
Title: SVGColorProfileElement
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/SVGColorProfileElement/local does not exist
    • /en-US/docs/Web/API/SVGColorProfileElement/name does not exist
    • /en-US/docs/Web/API/SVGColorProfileElement/renderingIntent does not exist

URL: /en-US/docs/Web/API/SVGAElement
Title: SVGAElement
on GitHub
Flaw count: 12

  • macros:
    • /en-US/docs/Web/API/HTMLHyperlinkElementUtils does not exist
    • /en-US/docs/Web/API/SVGAElement/download does not exist
    • /en-US/docs/Web/API/SVGAElement/href does not exist
    • /en-US/docs/Web/API/SVGAElement/hreflang does not exist
    • /en-US/docs/Web/API/SVGAElement/ping does not exist
    • and 7 more flaws omitted

URL: /en-US/docs/Web/API/SVGForeignObjectElement
Title: SVGForeignObjectElement
on GitHub
Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/SVGForeignObjectElement/x does not exist
    • /en-US/docs/Web/API/SVGForeignObjectElement/y does not exist
    • /en-US/docs/Web/API/SVGForeignObjectElement/width does not exist
    • /en-US/docs/Web/API/SVGForeignObjectElement/height does not exist
    • /en-US/docs/Web/API/SVGLangSpace does not exist
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/SVGGlyphRefElement
Title: SVGGlyphRefElement
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/SVGGlyphRefElement/glyphRef does not exist
    • /en-US/docs/Web/API/SVGGlyphRefElement/format does not exist
    • /en-US/docs/Web/API/SVGGlyphRefElement/x does not exist
    • /en-US/docs/Web/API/SVGGlyphRefElement/y does not exist
    • /en-US/docs/Web/API/SVGGlyphRefElement/dx does not exist
    • and 1 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/SVGTRefElement
Title: SVGTRefElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub

URL: /en-US/docs/Web/API/SVGGradientElement
Title: SVGGradientElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGTextPathElement
Title: SVGTextPathElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGFEImageElement
Title: SVGFEImageElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGCursorElement
Title: SVGCursorElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGPatternElement
Title: SVGPatternElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGUseElement
Title: SVGUseElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGColorProfileElement
Title: SVGColorProfileElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGAElement
Title: SVGAElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGForeignObjectElement
Title: SVGForeignObjectElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/SVGGlyphRefElement
Title: SVGGlyphRefElement
on GitHub

No new external URLs

@foolip
Copy link
Contributor Author

foolip commented May 19, 2021

I've just done the easy thing of search and delete here. What's missing is to ensure that href is actually documented on the interfaces which include the SVGURIReference mixin:

  • SVGAElement
  • SVGFEImageElement
  • SVGFilterElement
  • SVGGradientElement
  • SVGImageElement
  • SVGMPathElement
  • SVGPatternElement
  • SVGScriptElement
  • SVGTextPathElement
  • SVGUseElement

chrisdavidmills
chrisdavidmills approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @foolip !

@chrisdavidmills chrisdavidmills merged commit c182ce9 into mdn:main May 19, 2021
@foolip
Copy link
Contributor Author

foolip commented May 19, 2021

@chrisdavidmills maybe I should have left this a draft, I was expecting to have to address #5111 (comment) before getting this merged :)

@foolip foolip deleted the rm-SVGURIReference branch May 19, 2021 09:32
@foolip
Copy link
Contributor Author

foolip commented May 19, 2021

@Elchi3 do you have any advice for how to do this, how have you dealt with this in previous mixin-demixing?

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills maybe I should have left this a draft, I was expecting to have to address #5111 (comment) before getting this merged :)

oop, sorry, itchy trigger finger ;-)

@foolip
Copy link
Contributor Author

foolip commented May 19, 2021

@chrisdavidmills no worries, I'll just send a follow-up PR :)

@foolip foolip mentioned this pull request May 19, 2021
Merged
@Elchi3 Elchi3 mentioned this pull request May 20, 2021
Closed
jpmedley added a commit that referenced this pull request May 20, 2021
@foolip @jpmedley
Document the href attributes on interfaces including SVGURIReference (#…
9efa08f 
…5112)

* Document the href attributes on interfaces including SVGURIReference

Follow-up to #5111.

* Apply suggestions from code review

Co-authored-by: Joe Medley <jmedley@google.com>

Co-authored-by: Joe Medley <jmedley@google.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foolip @chrisdavidmills