Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up SVGLocatable and SVGTransformable references #5146

Merged
merged 1 commit into from
May 20, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented May 20, 2021

These were mixin-like interfaces in SVG 1.1:
https://www.w3.org/TR/SVG11/types.html#InterfaceSVGLocatable
https://www.w3.org/TR/SVG11/types.html#InterfaceSVGTransformable

Happily, there were no separate pages, the related bits are mostly
already documented on SVGGraphicsElement:
https://developer.mozilla.org/en-US/docs/Web/API/SVGGraphicsElement

All that remains of these is now in the specifications tables.

These were mixin-like interfaces in SVG 1.1:
https://www.w3.org/TR/SVG11/types.html#InterfaceSVGLocatable
https://www.w3.org/TR/SVG11/types.html#InterfaceSVGTransformable

Happily, there were no separate pages, the related bits are mostly
already documented on SVGGraphicsElement:
https://developer.mozilla.org/en-US/docs/Web/API/SVGGraphicsElement

All that remains of these is now in the specifications tables.
@foolip foolip requested a review from a team May 20, 2021 11:16
@foolip foolip requested a review from a team as a code owner May 20, 2021 11:16
@foolip foolip requested review from jpmedley and removed request for a team May 20, 2021 11:16
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/SVG_2_support_in_Mozilla
Title: SVG 2 support in Mozilla
on GitHub
Flaw count: 20

  • macros:
    • /en-US/docs/Web/API/SVGColor does not exist
    • /en-US/docs/Web/API/SVGICCColor does not exist
    • /en-US/docs/Web/API/SVGElementInstance does not exist
    • /en-US/docs/Web/API/SVGElementInstanceList does not exist
    • /en-US/docs/Web/API/SVGUnknownElement does not exist
    • and 15 more flaws omitted

URL: /en-US/docs/Web/API/SVGForeignObjectElement
Title: SVGForeignObjectElement
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/SVGForeignObjectElement/x does not exist
    • /en-US/docs/Web/API/SVGForeignObjectElement/y does not exist
    • /en-US/docs/Web/API/SVGForeignObjectElement/width does not exist
    • /en-US/docs/Web/API/SVGForeignObjectElement/height does not exist
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/SVGGraphicsElement
Title: SVGGraphicsElement
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/SVGGraphicsElement/transform does not exist
    • /en-US/docs/Web/API/SVGGraphicsElement/getCTM does not exist
    • /en-US/docs/Web/API/SVGGraphicsElement/getScreenCTM does not exist

URL: /en-US/docs/Web/API/SVGLineElement
Title: SVGLineElement
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/SVGLineElement/x1 does not exist
    • /en-US/docs/Web/API/SVGLineElement/y1 does not exist
    • /en-US/docs/Web/API/SVGLineElement/x2 does not exist
    • /en-US/docs/Web/API/SVGLineElement/y2 does not exist

URL: /en-US/docs/Web/API/SVGRectElement
Title: SVGRectElement
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/SVGRectElement/x does not exist
    • /en-US/docs/Web/API/SVGRectElement/y does not exist
    • /en-US/docs/Web/API/SVGRectElement/width does not exist
    • /en-US/docs/Web/API/SVGRectElement/height does not exist
    • /en-US/docs/Web/API/SVGRectElement/rx does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/SVGPatternElement
Title: SVGPatternElement
on GitHub
Flaw count: 10

  • macros:
    • /en-us/docs/web/api/svgfittoviewbox (url: /en-US/docs/Web/API/SVGFitToViewBox) does not exist
    • /en-US/docs/Web/API/SVGFitToViewBox does not exist
    • /en-US/docs/Web/API/SVGPatternElement/patternUnits does not exist
    • /en-US/docs/Web/API/SVGPatternElement/patternContentUnits does not exist
    • /en-US/docs/Web/API/SVGPatternElement/patternTransform does not exist
    • and 5 more flaws omitted

URL: /en-US/docs/Web/API/SVGImageElement
Title: SVGImageElement
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/mozimageloadingcontent (url: /en-US/docs/Web/API/MozImageLoadingContent) does not exist
    • /en-US/docs/Web/API/SVGImageElement/crossOrigin does not exist
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/SVGMaskElement
Title: SVGMaskElement
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/SVGMaskElement/maskUnits does not exist
    • /en-US/docs/Web/API/SVGMaskElement/maskContentUnits does not exist
    • /en-US/docs/Web/API/SVGMaskElement/x does not exist
    • /en-US/docs/Web/API/SVGMaskElement/y does not exist
    • /en-US/docs/Web/API/SVGMaskElement/width does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/SVGSVGElement
Title: SVGSVGElement
on GitHub
Flaw count: 45

  • macros:
    • /en-us/docs/web/api/svgfittoviewbox (url: /en-US/docs/Web/API/SVGFitToViewBox) does not exist
    • /en-US/docs/Web/API/SVGFitToViewBox does not exist
    • /en-US/docs/Web/API/SVGSVGElement/x does not exist
    • /en-US/docs/Web/API/SVGSVGElement/y does not exist
    • /en-US/docs/Web/API/SVGSVGElement/width does not exist
    • and 40 more flaws omitted

External URLs

URL: /en-US/docs/Web/SVG/SVG_2_support_in_Mozilla
Title: SVG 2 support in Mozilla
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGForeignObjectElement
Title: SVGForeignObjectElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGGraphicsElement
Title: SVGGraphicsElement
on GitHub


URL: /en-US/docs/Web/API/SVGPolylineElement
Title: SVGPolylineElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGLineElement
Title: SVGLineElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGRectElement
Title: SVGRectElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGGElement
Title: SVGGElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGPolygonElement
Title: SVGPolygonElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGPatternElement
Title: SVGPatternElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGSwitchElement
Title: SVGSwitchElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGImageElement
Title: SVGImageElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGTextElement
Title: SVGTextElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGMaskElement
Title: SVGMaskElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGSVGElement
Title: SVGSVGElement
on GitHub

No new external URLs

Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip @rachelandrew

FYI, you are both trolling the same content under pay of the same org.

@jpmedley jpmedley merged commit ac7d3ba into mdn:main May 20, 2021
@foolip foolip deleted the rm-SVGLocatable-SVGTransformable branch May 20, 2021 17:20
@foolip
Copy link
Contributor Author

foolip commented May 20, 2021

@jpmedley I'm just cleaning things up if I see a PR updating the data in BCD and it seems to me that entry could be removed entirely instead. @rachelandrew are you working on SVG specifically, or also doing drive-by cleanup here and there?

@rachelandrew
Copy link
Collaborator

@foolip at the moment I'm documenting a couple of completely missing interfaces, I've just done https://developer.mozilla.org/en-US/docs/Web/API/SVGMarkerElement and I'm going to do the missing SVGPointList next.

@foolip
Copy link
Contributor Author

foolip commented May 21, 2021

@rachelandrew I see, that's great, and shouldn't conflict much if at all with cleanup of no-longer-existing interfaces I come across. You might see them referenced in pages you look at for inspiration though, and the list of such interfaces that probably shouldn't be mentioned in new docs is in mdn/browser-compat-data#7752.

@jpmedley
Copy link
Collaborator

Fortunately, we don't don't document what's not in Chrome unless it's new and coming to Chrome. I could only find three of those interfaces in our IDL, where they're rendered as mixins. There should be no problem documenting on the interfaces that use them.

  • SVGFilterPrimitiveStandardAttributes
  • SVGURIReference
  • SVGTests

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants