Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that SubtleCrypto: deriveBits() length must be multiple of 8 #5529

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Document that SubtleCrypto: deriveBits() length must be multiple of 8 #5529

merged 7 commits into from
Jul 14, 2021

Conversation

sideshowbarker
Copy link
Collaborator

Fixes #1671

@sideshowbarker sideshowbarker requested a review from a team as a code owner June 1, 2021 09:03
@sideshowbarker sideshowbarker requested review from jpmedley and removed request for a team June 1, 2021 09:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021 •
edited

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/SubtleCrypto/deriveBits
Title: SubtleCrypto.deriveBits()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CryptoKey
Title: CryptoKey
on GitHub

No new external URLs

(this comment was updated 2021-06-28 16:36:58.163996)

@sideshowbarker
Copy link
Collaborator Author

@twiss I’d appreciate your review of the diff at f9f4ee6. (The other change in this PR branch is a housekeeping change).

@sideshowbarker sideshowbarker mentioned this pull request Jun 1, 2021
Closed
@sideshowbarker
Copy link
Collaborator Author

@twiss I pushed some further commits in response to your review comments, so this is now ready for re-review

twiss
twiss reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me now 👍 Just one nitpick:

files/en-us/web/api/subtlecrypto/derivebits/index.html Outdated Show resolved Hide resolved
@sideshowbarker @twiss
Update files/en-us/web/api/subtlecrypto/derivebits/index.html
8b76b04 
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
@sideshowbarker
Copy link
Collaborator Author

@jpmedley this one should be ready for your review now

@sideshowbarker
Copy link
Collaborator Author

@jpmedley This seems to be waiting on your review

@teoli2003 teoli2003 merged commit 879f912 into main Jul 14, 2021
@teoli2003 teoli2003 deleted the sideshowbarker/SubtleCrypto-deriveBits-document-length-requirement branch July 14, 2021 08:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twiss twiss twiss left review comments

@teoli2003 teoli2003 teoli2003 approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubtleCrypto.deriveBits() with PBKDF2 and output length > 2048 bits
3 participants
@sideshowbarker @twiss @teoli2003