Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTTPS for mozilla.org links #607

Merged
merged 1 commit into from Dec 23, 2020
Merged

fix: HTTPS for mozilla.org links #607

merged 1 commit into from Dec 23, 2020

Conversation

nschonni
Copy link
Contributor

No description provided.

@nschonni nschonni requested review from a team as code owners December 23, 2020 17:27
@nschonni nschonni requested a review from a team December 23, 2020 17:27
@nschonni nschonni requested a review from a team as a code owner December 23, 2020 17:27
@nschonni nschonni requested a review from a team December 23, 2020 17:27
@nschonni nschonni requested a review from a team as a code owner December 23, 2020 17:27
vkWeb
vkWeb approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni Always glad to see your PR! Thanks for helping us through out man! <3

@nschonni
Copy link
Contributor Author

lol, I run out of stuff eventually, just easier at the start 😄

@vkWeb
Copy link
Member

vkWeb commented Dec 23, 2020

Note: we have http links wrapped with <a> like this: <a src="https://www.mozilla.org">http://www.mozilla.org</a>.

@nschonni any chance this can be dealt with in one of your future PR? 😅

@chrisdavidmills chrisdavidmills merged commit 9496777 into mdn:main Dec 23, 2020
@nschonni nschonni deleted the https-mozilla.org branch December 23, 2020 22:03
@nschonni
Copy link
Contributor Author

@vkWeb oops, I'll submit something separate to fix those others in the text values

@vkWeb
Copy link
Member

vkWeb commented Dec 23, 2020

@nschonni Can't thanks enough <3.

@nschonni nschonni mentioned this pull request Dec 24, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@vkWeb vkWeb vkWeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nschonni @vkWeb @chrisdavidmills