Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-spec msg for PushManager.* #6223

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

teoli2003
Copy link
Member

This is part of #6108.

We are dealing with features that are no more on the standard track (deprecated), with bcd tables. The idea is to remove the {{Specifications}}, that implies missing data in this case, without putting back an outdated table like before

Dealing with the 4 PushManager methods: hasPermission, register, unregister, and registrations.

  • I removed the {{Specifications}} macro and replaced it with a basic text.
  • I updated the text at the top too.
  • I delete PushRegistrationManager not implemented at all (and not on standard track)
  • I updated the Push API page not to mention PushRegistrationManager anymore.

I removed some gremlins too.

@teoli2003 teoli2003 requested review from a team as code owners June 22, 2021 10:58
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team June 22, 2021 10:58
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PushManager/unregister
Title: PushManager.unregister()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/DOMRequest does not exist
    • /en-US/docs/Web/API/DOMRequest does not exist

URL: /en-US/docs/Web/API/PushManager/register
Title: PushManager.register()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/DOMRequest does not exist
    • /en-US/docs/Web/API/DOMRequest does not exist

URL: /en-US/docs/Web/API/PushManager/registrations
Title: PushManager.registrations()
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/DOMRequest does not exist
    • /en-US/docs/Web/API/DOMRequest does not exist

External URLs

URL: /en-US/docs/Web/API/PushManager
Title: PushManager
on GitHub

No external URLs


URL: /en-US/docs/Web/API/PushManager/unregister
Title: PushManager.unregister()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PushManager/register
Title: PushManager.register()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PushManager/hasPermission
Title: PushManager.hasPermission()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PushManager/registrations
Title: PushManager.registrations()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Push_API
Title: Push API
on GitHub

Copy link
Collaborator

@Rumyra Rumyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @teoli2003 👍

@Rumyra Rumyra merged commit d208ee5 into mdn:main Jun 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants