Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF90: Minor tweaks to JavaScript class private features #6323

Merged
merged 1 commit into from Jun 25, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jun 25, 2021

Trivial docs follow up for #5386

I just reviewed the updated private class features docs for FF90. These already did pretty much everything I thought needed doing. All this does is:

  1. Release note - referred to private class fields and method. Strictly accurate, but worth mentioning static methods here.
  2. Fixed up a couple of link titles to "Private class fields" which has now been named private class features.

I don't think anything else "needs" to be done.

@hamishwillee hamishwillee requested review from a team as code owners June 25, 2021 05:22
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team June 25, 2021 05:22
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/90
Title: Firefox 90 for developers
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/image-set() redirects to /en-US/docs/Web/CSS/image/image-set()

URL: /en-US/docs/Web/JavaScript/Reference/Classes
Title: Classes
on GitHub
Flaw count: 2

  • bad_bcd_links:
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/90
Title: Firefox 90 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Classes
Title: Classes
on GitHub

No new external URLs

@hamishwillee
Copy link
Collaborator Author

@meyerweb Nice job on the JS updates.

In the top level Classes doc it refers to private fields and to Static methods and properties. However it does not talk about private methods, or static private methods or static private fields.

Is that something we should update too?

@sideshowbarker sideshowbarker merged commit f5fceb8 into mdn:main Jun 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants