Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix HTMLOrForeignElement.dataset to (HTML,SVG)Element.dataset #6519

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jul 2, 2021

There no spec that calls this HTMLOrForeignElement as of now and even if it would, this is a mixin. Docs should be under HTMLElement and SVGElement.

@Elchi3 Elchi3 requested review from a team as code owners July 2, 2021 09:38
@Elchi3 Elchi3 requested a review from a team July 2, 2021 09:38
@Elchi3 Elchi3 requested a review from a team as a code owner July 2, 2021 09:38
@Elchi3 Elchi3 requested review from Rumyra and removed request for a team July 2, 2021 09:38
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Preview URLs

Flaws

URL: /en-US/docs/Learn/HTML/Howto/Use_data_attributes
Title: Using data attributes
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset

URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
on GitHub
Flaw count: 17

  • macros:
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset
    • /en-US/docs/Web/API/Worker/importScripts does not exist
    • /en-US/docs/Web/API/MozSocial does not exist
    • /en-US/docs/Web/API/Navigator/mozSocial does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Statements/for_each...in
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Statements/Legacy_generator_function
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Simple_Push_API
    • and 8 more flaws omitted

URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
on GitHub
Flaw count: 44

  • macros:
    • /en-US/docs/Web/API/DocumentAndElementEventHandlers does not exist
    • /en-US/docs/Web/API/TouchEventHandlers does not exist
    • /en-US/docs/Web/API/HTMLElement/attributeStyleMap does not exist
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/HTMLElement/draggable does not exist
    • and 28 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/HTMLElement/dataset
Title: HTMLElement.dataset
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/Intersection_Observer_API/Timing_element_visibility
Title: Timing element visibility with the Intersection Observer API
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/parseFloat() does not exist
  • sectioning:
    • Excess <h2> tag that is NOT at root-level (id='Styling_the_site_with_CSS', text='Styling the site with CSS')
    • Excess <h2> tag that is NOT at root-level (id='Tying_it_together_with_JavaScript', text='Tying it together with JavaScript')

URL: /en-US/docs/Web/API/DOMStringMap
Title: DOMStringMap
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset

URL: /en-US/docs/Web/API/SVGElement
Title: SVGElement
on GitHub
Flaw count: 17

  • macros:
    • /en-US/docs/Web/API/DocumentAndElementEventHandlers does not exist
    • /en-US/docs/Web/API/SVGElementInstance does not exist
    • /en-US/docs/Web/API/SVGElement/attributeStyleMap does not exist
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset
    • /en-US/docs/Web/API/SVGElement/className does not exist
    • and 5 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/HTML/Using_data_attributes
    • Can't resolve /en-US/docs/Web/API/SVGElement/abort_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/resize_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/scroll_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/unload_event
    • and 1 more flaws omitted
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/HTML/Global_attributes
Title: Global attributes
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Global_attributes/exportparts
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Learn/HTML/Howto/Use_data_attributes
Title: Using data attributes
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLElement/dataset
Title: HTMLElement.dataset
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Intersection_Observer_API/Timing_element_visibility
Title: Timing element visibility with the Intersection Observer API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DOMStringMap
Title: DOMStringMap
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGElement
Title: SVGElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Global_attributes
Title: Global attributes
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 76f6515 into mdn:main Jul 3, 2021
@Elchi3 Elchi3 deleted the demix-htmlorforeignelement-dataset branch July 5, 2021 07:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants