colorManagement in browserSettings #7893
Conversation
Documentation updates for the addition of support for colorManagement in browserSettings. Also aligned the title of contextMenuShowEvent to include browserSettings. as it is with the other browserSettings objects. See [Bug 1714428](https://bugzilla.mozilla.org/show_bug.cgi?id=1714428)
|
The It’s currently |
|
@sideshowbarker Making this slug all lowercase doesn't seem to have worked either. Other slugs appear to use casing e.g. Mozilla/Add-ons/WebExtensions/API/browserSettings/contextMenuShowEvent in the other file updated in this PR. |
It’s not the slug that the CI is failing on — it’s the actual directory name on the filesystem. The slugs should actually be mixed case, so that slug was already correct as it was. |
|
@sideshowbarker Thanks, everything is green now on the tests, but I need approval again. |
I think it needs to be approved by @rpl or someone else from the @mdn/yari-content-mozilla-add-ons team |
|
Thanks @rebloor - are you adding the browser compat data for |
|
@rebloor lgtm, as @Rumyra mentioned in #7893 (comment) As a side note @mixedpuppy reviewed these changes to the |
|
Thanks @rpl 👍 Apologies for the slightly blunt compat data comment 🙏 @rebloor this is the browser compat file that needs updating https://github.com/mdn/browser-compat-data/blob/main/webextensions/api/browserSettings.json with the addition of |
|
@Rumyra The compatibility table were there all along :-) |
|
Hah - thank you @rebloor :D I'm happy to merge, but I'll wait to see if @mixedpuppy has any comments 👍 |
@Rumyra I just signed off it from our (Add-ons team) perspective (also briefly talked about it with @mixedpuppy to let him know this was pending sign-off on our side and that I was going to approve it in a few minutes). |
|
@mkaply can you add to the docs an explanation why this setting may be used? |
|
@mkaply Do you have any information on why developers would use the settings? |
|
Yes, sorry. This is useful when you are viewing images or videos in the browser and you want to view them using their original color profile as opposed to having the browser or operating system modify the color. |
|
@mixedpuppy The additional information you asked for is now there. Please let me know if is anything else. |
rebloor
requested review from
Rumyra,
mixedpuppy and
rpl
and removed request for
a team
|
|
||
| <p>A {{WebExtAPIRef("types.BrowserSetting", "BrowserSetting")}} object used to query and set the browser's color management features.</p> | ||
|
|
||
| <p>By default, Firefox applies color management to tagged media and defaults to sRGB for untagged media. This behavior means that some untagged media, such as that used in animation and movie production, may have undesired color corrections made to it. Use these settings to prevent that. However, note that these are browser settings, so you may want to modify them only while you're extension is active.</p> |
There was a problem hiding this comment.
I'm not clear what "However, note that these are browser settings, so you may want to modify them only while you're extension is active." means. I assume that the first part means "Changing this setting affects the entire browser". I'm not sure if "active" refers to the enabled state of the addon, or if it means that the addon is e.g. making the change for something in a specific tab. If the former, when we disable the addon, all its settings are undone, so the addon doesn't need to worry about that.
@mkaply I also don't know what "tagged media" is. Is there a way for an addon to tag media so that it can prevent that media from having sRGB applied?
There was a problem hiding this comment.
I've removed the "browser wide" comment given that this should be adequately covered by the comments on API's introductory page.
For information on "tagged media." This is information embedded in the image or video to indicate the profile to apply when it's rendered. I couldn't find a really good reference, but this might help: https://www.graphicartsmedia.com/magazine-stand/stabilizing-colour-management-with-varying-web-browsers/. So by default, if the image isn't tagged Firefox applies sRGB, otherwise it applies the color profile tagged in the image. Does that help?
There was a problem hiding this comment.
@mixedpuppy Please let me know if you're request for changes has been addressed, thanks
There was a problem hiding this comment.
Can we link "tagged media" to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/3.5/ICC_color_correction_in_Firefox ? r+ with that (or better link if one is avialable)
Documentation updates for the addition of support for colorManagement in browserSettings. Also aligned the title of contextMenuShowEvent to include browserSettings. as it is with the other browserSettings objects.
See Bug 1714428