Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF92: selectionchange_event - can be fired on textarea and input #8222

Merged
merged 12 commits into from Aug 25, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Aug 23, 2021

FF92 adds support for this spec change. Essentially the selectedchange event used to just be fired on document and tell you something about the selected nodes (in a Selection object). The spec change means that you can use the same event to find out about selection within a text control (input or text area)

The change adds information in the global onselectionchanged handler to note the new events. There are also new event docs added for HTMLInputElement/HTMLTextAreaElement. BCD follows in mdn/browser-compat-data#12126.

This is first part of docs for #7755

@hamishwillee hamishwillee requested a review from a team as a code owner August 23, 2021 07:19
@hamishwillee hamishwillee requested review from jpmedley and removed request for a team August 23, 2021 07:19
@hamishwillee hamishwillee marked this pull request as draft August 23, 2021 07:20
@hamishwillee hamishwillee removed the request for review from jpmedley August 23, 2021 07:20
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2021

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLTextAreaElement
Title: HTMLTextAreaElement
on GitHub
Flaw count: 5

  • macros:
    • This macro has been deprecated, and should be removed.
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/HTMLTextAreaElement/selectionchange_event
Title: HTMLTextAreaElement: selectionchange event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.HTMLTextAreaElement.selectionchange_event

URL: /en-US/docs/Web/API/HTMLInputElement
Title: HTMLInputElement
on GitHub
Flaw count: 30

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/align does not exist
    • /en-US/docs/Web/API/HTMLInputElement/useMap does not exist
    • /en-US/docs/Web/API/HTMLInputElement/mozSetFileArray does not exist
    • /en-US/docs/Web/API/HTMLInputElement/mozSetFileNameArray redirects to /en-US/docs/Web/API/HTMLInputElement
  • broken_links:
    • Can't resolve /en-US/docs/Extensions/Using_the_DOM_File_API_in_chrome_code
    • Can't resolve /en-US/docs/Mozilla/Firefox/Multiprocess_Firefox/The_message_manager
    • Can't resolve /en-US/docs/Mozilla/Firefox/Multiprocess_Firefox/Limitations_of_frame_scripts
    • Can't resolve /en-US/docs/Web/API/GlobalEventHandlers/onsearch
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 17 more flaws omitted

URL: /en-US/docs/Web/API/HTMLInputElement/selectionchange_event
Title: HTMLInputElement: selectionchange event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.HTMLInputElement.selectionchange_event

URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/SVGElement/abort_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/resize_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/scroll_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/unload_event

External URLs

URL: /en-US/docs/Web/API/Document/selectionchange_event
Title: Document: selectionchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLTextAreaElement
Title: HTMLTextAreaElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLTextAreaElement/selectionchange_event
Title: HTMLTextAreaElement: selectionchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers/onselectionchange
Title: GlobalEventHandlers.onselectionchange
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLInputElement
Title: HTMLInputElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLInputElement/selectionchange_event
Title: HTMLInputElement: selectionchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub

No new external URLs

(this comment was updated 2021-08-25 04:14:22.886182)

@hamishwillee hamishwillee requested a review from a team as a code owner August 24, 2021 02:12
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team August 24, 2021 02:12
hamishwillee and others added 8 commits August 25, 2021 14:11
…x.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
…ex.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
…ex.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
…ex.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
…index.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
…index.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
…index.html

Co-authored-by: Michael[tm] Smith <mike@w3.org>
@hamishwillee
Copy link
Collaborator Author

Thanks for this one too. Lots of typo's sorry.

@hamishwillee hamishwillee merged commit d77239c into mdn:main Aug 25, 2021
@hamishwillee hamishwillee deleted the selectionchange_event branch August 25, 2021 04:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants