Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1938: ARIA - Option Role #9019

Merged
merged 8 commits into from Nov 4, 2021
Merged

Fixes #1938: ARIA - Option Role #9019

merged 8 commits into from Nov 4, 2021

Conversation

zacnomore
Copy link
Contributor

Fixes #1938

Create a page for the ARIA role option

This is the first page I am creating, I would appreciate any guidance!

The listbox page's second spec has a broken link. I used that as a template for this, I was unable to figure out how to correct it

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/option_role
Title: ARIA: option role
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/option_role
Title: ARIA: option role
on GitHub

(this comment was updated 2021-10-07 01:07:10.221915)

Copy link
Contributor

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial feedback on what i had some time to review. note that i didn't get to read everything, but this is just what jumped out at me.

@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Oct 7, 2021
@zacnomore zacnomore marked this pull request as ready for review October 7, 2021 01:05
@zacnomore zacnomore requested a review from a team as a code owner October 7, 2021 01:05
@estelle estelle merged commit 29b507b into mdn:main Nov 4, 2021
@zacnomore zacnomore deleted the option-role-page branch November 5, 2021 16:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "ARIA: listbox role": broken link Option Role"
3 participants