New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class static initialization blocks #9281
Conversation
PS Before we are done will also cross link to the new doc from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes#static_methods_and_properties |
Thanks so much @hamishwillee - I'm taking a look now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I think this is good @hamishwillee - I get it's paraphrasing, but I think that's fine.
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
@himanshugarg Your note appears to have gone. But in summary you're most welcome to provide feedback on anything and everything. I will be integrating the suggestions already made and tidying this up again before submitting. |
…ialization_blocks/index.md Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
I don't remember commenting here, but if there was a note from me, it must have been unrelated and in error. Either way thanks for your note! EDIT: I think you meant the other Himanshu! i.e. |
…ialization_blocks/index.md Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
@Rumyra Great - I've accepted your change. Will do the release note and interactive example separately. Ready for re-review. I think this is "OK" as reference. I'm just disappointed that the source materials show a deeper understanding of the practical use of the feature. I've linked them though, so nothing is lost. |
I like to suggest typo fixes to you as a reader, not as a reviewer, I hope this change will not waste your time and energy in reviewing and verifying it. |
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/classes/class_static_initialization_blocks/index.md
Outdated
Show resolved
Hide resolved
…ialization_blocks/index.md Co-authored-by: Himanshu <74658643+digi-booster@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Himanshu <74658643+digi-booster@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Himanshu <74658643+digi-booster@users.noreply.github.com>
…ialization_blocks/index.md Co-authored-by: Himanshu <74658643+digi-booster@users.noreply.github.com>
Sure, love a good typo fix :-) |
https://bugzilla.mozilla.org/show_bug.cgi?id=1725689 adds support for static initialisation blocks in classes (ES13 feature). This PR adds docs - part of the work in #8606
@Rumyra I am not particularly confident of this. I don't think anything is "wrong" - I just don't think it adds anything over what the explainers from v8.dev or the 2ality.blog do. That's the problem with not being particularly confident with JavaScript - it is easy enough to paraphrase, but not do anything innovative.
Anyway, I have left in draft, so it doesn't merge until you have a chance to look at it.
I will add an interactive exmaple if you think this is otherwise OK.