-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RTCOfferAnswerOptions and RTC[Offer/Answer]Options from MDN #9748
Conversation
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-10-22 06:53:45.150554) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any reference to voiceActivityDetection
in the specification: https://w3c.github.io/webrtc-pc/#offer-answer-options . (It looks like it has been removed: https://www.w3.org/TR/2019/CR-webrtc-20191213/)
It looks like:
RTCOfferAnswerOptions
(the base object) is an empty objectRTCAnswerOptions
is an empty objectRTCOfferOptions
contains a single booleaniceRestart
So effectively:
RTCPeerConnection.createAnswer()
doesn't accept any options (I mean, I guess you can pass an empty object, but...)
RTCPeerConnection.createOffer()
accepts an object with a single property iceRestart
, which is a boolean defaulting to false (I think the description of this property should explicitly note that it's a boolean, which they don't currently do).
Hey - just wondering what the status of this pr is currently. I'm about to convert the firefox folder to markdown and this touches a few of those files. Let me know - I can help fix it up if there's no more feedback on it 👍 |
Sorry, I've been slow re-reviewing this but will get to it today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @queengooborg , and sorry to be slow reviewing. Just a couple of other bits.
files/en-us/web/api/rtcrtpsynchronizationsource/voiceactivityflag/index.md
Outdated
Show resolved
Hide resolved
@@ -106,7 +106,7 @@ These are, in order: | |||
- `mediaConstraints` | |||
- : An object conforming to the {{domxref("MediaConstraints")}} dictionary specifying the constraints to use when starting the connection. We want an audio-only connection, so `video` is `false`, while `audio` is `true`. | |||
- `offerOptions` | |||
- : An `RTCOfferOptions` object providing options to specify when calling {{domxref("RTCPeerConnection.createOffer()")}}. In this case, we state that we want to receive audio but not video. | |||
- : An object object providing options to specify when calling {{domxref("RTCPeerConnection.createOffer()")}}. In this case, we state that we want to receive audio but not video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is using the "legacy properties" I think it is out of scope to fix it in this PR but we should file a follow-up issue.
Co-authored-by: wbamberg <will@bootbonnet.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks great now. Thanks for all your work on it @queengooborg !
This PR removes the documentation for the
RTCOfferAnswerOptions
,RTCOfferOptions
, andRTCAnswerOptions
dictionaries from MDN, folding their data into the two respective methods that use it. Correlates with its removal in BCD, see mdn/browser-compat-data#12819.