-
Notifications
You must be signed in to change notification settings - Fork 184
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
adding percentage as an option in alpha-value, angle as an option in …
…hue, and alpha-value as an optional fourth parameter in hsl() and rgb(), as per CSS4 color
- Loading branch information
1 parent
0492381
commit b021178
Showing
1 changed file
with
15 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b021178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, obviously something went totally wrong here. I assume you committed your changes from an older branch and didn't rebase it before merging it into master (which shouldn't be done directly).
Sebastian
b021178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, dammnit. I didn't remove any of the extra stuff that is removed here. I only updated alpha-value, hue, hsl() and rgb(). I'm positive I updated the repo before I submitted my changes ;-( Ooooh, I hate Git so much.
So how do I reverse these changes?
And how do I make sure this doesn't happen again?
b021178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already created PR #38 to revert the changes.
I'm not a champ in git myself, so I'm not sure what happened in this case. What I do is to create a branch for every change I make and rebase it on origin/master when there were commits to master in the meantime.
When #38 is merged, we can apply your changes again.
Sebastian