Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort css.json alphabetically #188

Merged
merged 6 commits into from
Apr 6, 2018
Merged

Sort css.json alphabetically #188

merged 6 commits into from
Apr 6, 2018

Conversation

pkuczynski
Copy link
Contributor

@pkuczynski pkuczynski commented Feb 28, 2018

No description provided.

@pkuczynski
Copy link
Contributor Author

@wbamberg conflicts solved. Can we get this one merged too?

@pkuczynski
Copy link
Contributor Author

@lahmatiy this should go first before #189

@pkuczynski
Copy link
Contributor Author

@lahmatiy conflicts solved. Can we get it merged?

@wbamberg
Copy link
Contributor

wbamberg commented Apr 6, 2018

As well as reordering, this adds a new property referToLineBox - is that intended?

@wbamberg
Copy link
Contributor

wbamberg commented Apr 6, 2018

Apart from that, this does seem identical to the original except for the ordering.

@pkuczynski
Copy link
Contributor Author

That's because it was removed in master, and I didn't notice. Good catch! referToLineBox removed now, so you can merge :)

@pkuczynski
Copy link
Contributor Author

I fired up another PR for schema validation #196. Have a look and let me know what you think?

@pkuczynski
Copy link
Contributor Author

@wbamberg can we get this PR merged in, as there are a couple of others spined-off from this one.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work, @pkuczynski !

@wbamberg wbamberg merged commit aaf92a9 into mdn:master Apr 6, 2018
@pkuczynski pkuczynski deleted the sort-css-json branch April 6, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants