Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <transform-function> syntax #223

Merged
merged 1 commit into from
May 10, 2018
Merged

Fix <transform-function> syntax #223

merged 1 commit into from
May 10, 2018

Conversation

lahmatiy
Copy link
Contributor

@lahmatiy lahmatiy commented May 6, 2018

Previously <transform-function> syntax describes one or more functions in any order repeated one or more times. However, according to spec it should be a regular enum. Repetition is defined in <transform-list>.
Although the old syntax is quite correct (can be used for a value matching), it is overwhelmed. This commit simplifies the syntax.
There is no <transform-function> syntax description in CSS Transforms Module Level 1, but it can be generated by a description.

Previously syntax describes one or more functions in any order repeated one or more times. However, according to spec it should be a regular enum. Repetition is defined in `transform-list`.
Although the old syntax is quite correct (can be used for a value matching), it is overwhelmed. This commit simplifies the syntax.
There is no `<transform-function>` syntax description in [CSS Transforms Module Level 1](https://www.w3.org/TR/css-transforms-1/#typedef-transform-function), but it can be generated by a description.
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wbamberg wbamberg merged commit 3a2683c into mdn:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants