Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): Add the env(…) function syntax #326

Merged
merged 1 commit into from Nov 23, 2018
Merged

feat(css): Add the env(…) function syntax #326

merged 1 commit into from Nov 23, 2018

Conversation

ExE-Boss
Copy link
Contributor

review?(@chrisdavidmills)

@ExE-Boss ExE-Boss changed the title feat(css): Add the env(…) function syntax feat(css): Add the env(…) function Nov 22, 2018
@ExE-Boss ExE-Boss changed the title feat(css): Add the env(…) function feat(css): Add the env(…) function syntax Nov 22, 2018
chrisdavidmills
chrisdavidmills suggested changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the square brackets should be omitted. the spec says

env( <custom-ident> , <declaration-value>? )

@ExE-Boss
Copy link
Contributor Author

@chrisdavidmills But that would require prop: env(safe-area-inset-top,) to be valid and prop: env(safe-area-inset-top) to be invalid, but as we all know, it’s the other way around, so the spec is incorrect.

chrisdavidmills
chrisdavidmills approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I getcha. OK, approving this then.

@chrisdavidmills chrisdavidmills merged commit 810529f into mdn:master Nov 23, 2018
@ExE-Boss ExE-Boss deleted the css/syntaxes/env branch November 23, 2018 21:23
@ExE-Boss ExE-Boss mentioned this pull request Jan 1, 2019
Closed
@tabatkins
Copy link

Nope, spec is correct, see the definition of commas as used in CSS value definition syntax

@chrisdavidmills chrisdavidmills mentioned this pull request Jan 7, 2019
Merged
@chrisdavidmills
Copy link
Contributor

Thanks @tabatkins for the clarification. This one had me confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ExE-Boss @tabatkins @chrisdavidmills