Added proper groups schema validation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahmatiy
reviewed
Jun 30, 2017
css/properties.schema.json
Outdated
| @@ -12,12 +12,53 @@ | |||
| } | |||
| } | |||
| }, | |||
| "stringList": { | |||
| "groupList": { | |||
| "type": "array", | |||
| "minItems": 1, | |||
| "uniqueItems": true, | |||
| "items": { | |||
There was a problem hiding this comment.
Should be "$ref": "definitions.json#/groupList"?
There was a problem hiding this comment.
Thanks for pointing that out! This got actually redundant, because we have the data in definitions.json. So I just removed this item in a2f2373.
Sebastian
|
It's awesome! Would be cool to add other common enums to |
Yes, that's the goal. This change is just the first step. Sebastian |
Elchi3
approved these changes
Jul 4, 2017
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a detailed groups validation to the JSON schema, split it out to a separate file and fixed/updated the groups within the data accordingly.