Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixtures to catalog #93

Closed
calvh opened this issue May 14, 2021 · 6 comments
Closed

Add fixtures to catalog #93

calvh opened this issue May 14, 2021 · 6 comments

Comments

@calvh
Copy link

calvh commented May 14, 2021

I suggest adding some mock data into a fixtures folder

https://docs.djangoproject.com/en/3.2/howto/initial-data/

@hamishwillee
Copy link
Collaborator

@calvh Thanks you. Fixtures certainly look like a useful feature (which I did not know about). But I'm not sure where they'd be useful in the context of this tutorial. Did you have any particular case in mind?

@calvh
Copy link
Author

calvh commented May 17, 2021

I think they'd be useful somewhere around Section 4 where you add data via the admin site. Some people (like me) find it tedious to manually enter data and may want an alternative. It might be worth having two sets of fixtures:

  1. One around section 4 so readers can quickly test out the site
  2. Another with the updated models including the borrower field introduced in section 8

Am I allowed to work on this or is this project restricted to members only?

@hamishwillee
Copy link
Collaborator

Am I allowed to work on this or is this project restricted to members only?

You are absolutely allowed to work on this and that would be much appreciated. I think probably it should be added only in one place, and that should probably be either at the end of, or "below", https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Models (this might require modification of the admin section too).

First, the updates should be made and tested as the demo project would be at the end of the models chapter. My concern here is that the models are not "complete" here (there are "challenges") so we need to be clear that whatever we advise works at that point. Then further we should have an update as a PR to https://github.com/mdn/django-locallibrary-tutorial and to the docs.

Does that make sense?

@calvh
Copy link
Author

calvh commented May 18, 2021

Yes, thank you. I will draft some changes and put them here before I make a PR.

@hamishwillee
Copy link
Collaborator

No, thank you - I'm looking forward to learning something new :-)

@hamishwillee
Copy link
Collaborator

Closing as no action taken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants