Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use switch, srcObject, return response.blob. Attempt to make video download not one time. #28

Merged
merged 2 commits into from Sep 21, 2018
Merged

Use switch, srcObject, return response.blob. Attempt to make video download not one time. #28

merged 2 commits into from Sep 21, 2018

Conversation

ZaneHannanAU
Copy link
Contributor

@ZaneHannanAU ZaneHannanAU commented Sep 20, 2018 •
edited

Essentially increase usability and not give errors in console.

Currently; the abort does not trigger after fetch starts and will error in console.

chrisdavidmills
chrisdavidmills suggested changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work; it returns the error "Download error: Value being assigned to HTMLMediaElement.srcObject does not implement interface MediaStream." - I think this is because srcObject needs to be passed a MediaStream instance, not the blob directly?

@ZaneHannanAU
Copy link
Contributor Author

Ah… oops yeah…

@ZaneHannanAU
Copy link
Contributor Author

... fixed; thank you.

Not going to try to use mediastream... that's a whole other can of worms.

chrisdavidmills
chrisdavidmills approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is fine for now. Thanks for the improvements!

@chrisdavidmills chrisdavidmills merged commit 1d77ac2 into mdn:master Sep 21, 2018
schalkneethling pushed a commit that referenced this pull request Aug 13, 2022
@chrisdavidmills
Merge pull request #28 from Zunino/gh-pages
5cbcb43 
Minor adjustments to the setup instructions
schalkneethling pushed a commit that referenced this pull request Aug 15, 2022
Merge pull request #28 from AdrianSkar/AdrianSkar-patch-1
a4fcc3e 
refactor[response]: variable declarations + log descriptions
schalkneethling pushed a commit that referenced this pull request Sep 11, 2022
Merge pull request #28 from greglnye/gh-pages
0ce4113
schalkneethling pushed a commit that referenced this pull request Sep 26, 2022
Merge pull request #28 from mdn/prepare-to-move-repo
b8e38b6 
chore: prepare to move repo to dom-examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZaneHannanAU @chrisdavidmills