Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onresize event handler example #86

Merged
merged 5 commits into from Jan 20, 2022
Merged

Conversation

AnilSeervi
Copy link
Contributor

Changes

  • Adds onresize event handler example in "resize-event" directory
  • Update README with description of the example
  • update http links in README to https

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AnilSeervi ! I had a few comments but this in general looks great.

I see though that you're using your master branch for this PR - maybe you want to use a different branch, in case you ever want to make more PRs to this repo?

README.md Outdated Show resolved Hide resolved
resize-event/index.html Show resolved Hide resolved
resize-event/index.html Outdated Show resolved Hide resolved
@wbamberg
Copy link
Contributor

This is part of the fix for mdn/content#10683.

@AnilSeervi
Copy link
Contributor Author

There is actually a macro for what I suggested in comment#10683.
I found it here - https://github.com/mdn/content/blob/main/files/en-us/web/api/indexeddb_api/using_indexeddb/index.md?plain=1#L1348
But the link it generated seems to be broken. - mdn/content#10941

@wbamberg
Copy link
Contributor

There is actually a macro for what I suggested in comment#10683. I found it here - https://github.com/mdn/content/blob/main/files/en-us/web/api/indexeddb_api/using_indexeddb/index.md?plain=1#L1348 But the link it generated seems to be broken. - mdn/content#10941

Interesting!

It looks like this is broken in the IndexedDB page because you must have previously called EmbedLiveSample - that tells Yari to generate the sample page. Otherwise the sample page doesn't exist. You can see it does work in https://developer.mozilla.org/en-US/docs/Web/API/datatransferitemlist/clear#example.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @AnilSeervi , this looks good to me. Unfortunately I introduced a merge conflict, let me know if you want me to try to fix it (or fix it yourself if you prefer).

Copy link
Contributor Author

@AnilSeervi AnilSeervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the conflict @wbamberg.
You can now go ahead and merge this :)

@wbamberg
Copy link
Contributor

Thanks @AnilSeervi !

@wbamberg wbamberg merged commit 7642bd3 into mdn:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants