New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onresize event handler example #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AnilSeervi ! I had a few comments but this in general looks great.
I see though that you're using your master
branch for this PR - maybe you want to use a different branch, in case you ever want to make more PRs to this repo?
This is part of the fix for mdn/content#10683. |
There is actually a macro for what I suggested in comment#10683. |
Interesting! It looks like this is broken in the IndexedDB page because you must have previously called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you @AnilSeervi , this looks good to me. Unfortunately I introduced a merge conflict, let me know if you want me to try to fix it (or fix it yourself if you prefer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've resolved the conflict @wbamberg.
You can now go ahead and merge this :)
Thanks @AnilSeervi ! |
Changes
onresize
event handler example in "resize-event" directoryhttp
links in README tohttps