Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express-locallibrary-tutorial: Heading hierarchy #277

Merged
merged 2 commits into from
May 3, 2024

Conversation

Crn0
Copy link
Contributor

@Crn0 Crn0 commented Apr 29, 2024

Description

Change the h4 tag to h2 and apply CSS to make h2 look like the rendered image.

Motivation

According to the mdn docs usage notes of the heading elements: h1 should be followed by h2.

Additional details

Related issues and pull requests

Relates to #33298

Copy link

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. Obviously there are many ways you could do this styling, but this works :-)

@hamishwillee hamishwillee merged commit a3d23cb into mdn:main May 3, 2024
3 checks passed
Copy link

github-actions bot commented May 3, 2024

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants