Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): Add example of draggable attribute #2220

Merged
merged 4 commits into from
Aug 2, 2023
Merged

feat(html): Add example of draggable attribute #2220

merged 4 commits into from
Aug 2, 2023

Conversation

NiedziolkaMichal
Copy link
Member

@NiedziolkaMichal NiedziolkaMichal commented Jul 18, 2022 •
edited

This is an interactive example of a global attribute draggable.

image

wbamberg
wbamberg reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this one, do you think it is worth waiting until we can have JS, and implementing a basic drag-and-drop example? There doesn't seem much point in having something draggable if you can't drop it :)

@NiedziolkaMichal
Copy link
Member Author

@wbamberg Yes, that's a good idea

@bsmth bsmth changed the title draggable Add HTML 'draggable' attribute Dec 7, 2022
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 7, 2023
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 10, 2023
Open
94 tasks
@NiedziolkaMichal NiedziolkaMichal changed the title Add HTML 'draggable' attribute feat(html): Add example of draggable attribute Feb 28, 2023
@NiedziolkaMichal NiedziolkaMichal removed the idle Issues and pull requests with no activity for three months. label Feb 28, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 31, 2023
@Josh-Cena Josh-Cena added the Content:HTML issues related to HTML examples. label Jul 31, 2023
@github-actions github-actions bot added merge conflicts 🚧 and removed idle Issues and pull requests with no activity for three months. labels Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

wbamberg
wbamberg approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great to me (and sorry to be so slow at reviewing these).

@wbamberg wbamberg requested a review from a team as a code owner August 2, 2023 18:29
@wbamberg wbamberg requested review from estelle and removed request for a team August 2, 2023 18:29
@wbamberg wbamberg merged commit 539676b into mdn:main Aug 2, 2023
5 checks passed
@mdn-bot mdn-bot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML issues related to HTML examples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NiedziolkaMichal @wbamberg @Josh-Cena @queengooborg