Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stage-deploy): build main with local bob #2370

Merged
merged 3 commits into from
Dec 24, 2022
Merged

fix(stage-deploy): build main with local bob #2370

merged 3 commits into from
Dec 24, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Dec 19, 2022

  1. Fixes the stage-deploy by using mdn-bob as specified in the package.json / yarn.lock.
  2. Run the workflow on pushes to main (continuous deployment).
  3. Format the workflow file with prettier (npx prettier -w).

Depends on #2388.

@welcome
Copy link

welcome bot commented Dec 19, 2022

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@caugner caugner marked this pull request as draft December 19, 2022 17:44
@caugner caugner changed the title fix(stage-deploy): use npm for bob fix(stage-deploy): use local bob Dec 23, 2022
@caugner caugner changed the title fix(stage-deploy): use local bob fix(stage-deploy): build main with local bob Dec 23, 2022
@caugner caugner marked this pull request as ready for review December 23, 2022 21:14
@caugner caugner requested review from nschonni and NiedziolkaMichal and removed request for nschonni December 23, 2022 21:22
@caugner
Copy link
Contributor Author

caugner commented Dec 23, 2022

@NiedziolkaMichal @nschonni Feel free to merge this PR after approving. This will not only fix the stage-deploy workflow, which was broken for months, but also makes sure the interactive-examples on stage are built on every push to main.

Once this works, we can replicate this for prod, except that we would probably want to build prod only once per day.

@NiedziolkaMichal
Copy link
Member

This looks good to me, but I am not into GitHub workflows, so it would be great if @nschonni could check it too.

@caugner
Copy link
Contributor Author

caugner commented Dec 24, 2022

Alternatively, @schalkneethling might be able to have a look next week. 🙏

Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this goes from using the live bob to the NPM published version, so i think it looks fine

@caugner caugner merged commit a418610 into main Dec 24, 2022
@caugner caugner deleted the fix-stage-deploy branch December 24, 2022 23:05
@welcome
Copy link

welcome bot commented Dec 24, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@caugner
Copy link
Contributor Author

caugner commented Dec 24, 2022

Thank you @nschonni! 🙏

@github-actions
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution!
Did you know we have a project board with high-impact contribution opportunities?
We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants