-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stage-deploy): build main with local bob #2370
Conversation
💖 Thanks for opening this pull request! 💖
|
5fe18bc
to
469b4d2
Compare
@NiedziolkaMichal @nschonni Feel free to merge this PR after approving. This will not only fix the Once this works, we can replicate this for prod, except that we would probably want to build prod only once per day. |
This looks good to me, but I am not into GitHub workflows, so it would be great if @nschonni could check it too. |
`npx prettier -w .github/workflows/stage-deploy.yml`
88eb997
to
c17a7bd
Compare
Alternatively, @schalkneethling might be able to have a look next week. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this goes from using the live bob to the NPM published version, so i think it looks fine
Congrats on merging your first pull request! 🎉🎉🎉 |
Thank you @nschonni! 🙏 |
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! |
stage-deploy
by usingmdn-bob
as specified in thepackage.json
/yarn.lock
.main
(continuous deployment).npx prettier -w
).Depends on #2388.