Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace marker example #2585

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix: Replace marker example #2585

merged 4 commits into from
Aug 17, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Aug 10, 2023

Replacing the ::marker example.

See #2175

CC @NiedziolkaMichal

@bsmth bsmth requested a review from a team as a code owner August 10, 2023 12:01
@bsmth bsmth requested review from dipikabh and removed request for a team August 10, 2023 12:01
@bsmth bsmth mentioned this pull request Aug 11, 2023
Closed
LeoMcA
LeoMcA approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsmth
Copy link
Member Author

bsmth commented Aug 17, 2023

Thank you, merging shortly 👍🏻

@bsmth bsmth merged commit deb64df into mdn:main Aug 17, 2023
5 checks passed
@bsmth bsmth deleted the replace-marker-example branch August 17, 2023 14:51
@mdn-bot mdn-bot mentioned this pull request Aug 17, 2023
Merged
@bsmth bsmth mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoMcA LeoMcA LeoMcA approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsmth @LeoMcA