Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): for font examples use 'rem' instead of 'em' #2604

Merged
merged 2 commits into from Sep 5, 2023

Conversation

OnkarRuikar
Copy link
Contributor

There is no change in output because we are not updating font on parent elements in these cases.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner September 4, 2023 04:58
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team September 4, 2023 04:58
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes more sense! Thanks @OnkarRuikar.

@chrisdavidmills chrisdavidmills merged commit 822ffc3 into mdn:main Sep 5, 2023
5 checks passed
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@OnkarRuikar OnkarRuikar deleted the css_no_em branch September 6, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants