Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.output class doesn't apply anymore #881

Closed
Elchi3 opened this issue May 3, 2018 · 2 comments
Closed

.output class doesn't apply anymore #881

Elchi3 opened this issue May 3, 2018 · 2 comments
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior. p1 We will address this soon and will provide capacity from our team for it in the next few releases.

Comments

@Elchi3
Copy link
Member

Elchi3 commented May 3, 2018

It seems like using .output in the CSS tab doesn't work anymore now that we're using Shadow DOM.

I see no hamster here, for example:
http://127.0.0.1:9090/pages/tabbed/select.html
CSS: https://github.com/mdn/interactive-examples/blob/master/live-examples/html-examples/forms/css/select.css

@wbamberg
Copy link
Contributor

wbamberg commented May 3, 2018

These are all the existing examples that use .output:

optgroup
option
legend
fieldset
select
datalist
input-file
input-email
input-radio
input-month
input-checkbox
input-image
input-datetime-local
input-date
input-color
picture
iframe

I think there are a couple of options, and I'd welcome opinions!

(1) have <div class="output"> wrapping the shadow DOM contents.
(2) make examples include the container element explicitly in the HTML pane.

The advantages of (1) are that existing examples don't need to change, and (more importantly IMO) we keep the HTML pane contents more narrowly focused on the example being demonstrated

The advantage of (2) is that there is less magic: it's clear what .output in the CSS pane refers to.

I think I'd vote for (1), to keep the HTML pane contents minimal. I think .output is pretty obvious.

@schalkneethling schalkneethling self-assigned this May 10, 2018
@schalkneethling schalkneethling added bug Indicates an unexpected problem or unintended behavior. p1 We will address this soon and will provide capacity from our team for it in the next few releases. labels May 10, 2018
@schalkneethling schalkneethling added this to the Q2 Sprint 3 milestone May 10, 2018
@schalkneethling
Copy link
Contributor

Acceptance Criteria

Examples that uses .output class for styling works again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior. p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Development

No branches or pull requests

4 participants