bug 1330357: Allow mixed case interest tags

kuma/core/managers.py

@@ -51,22 +51,9 @@ def all_ns(self, namespace=None):
 
         if namespace is not None:
             # Namespace requested, so generate filtered set
-            # TODO: Do this in the DB query? Might not be worth it.
-            #
-            # On databases with case-insensitive collation, we can end
-            # up with duplicate tags (the same tag, differing only by
-            # case, like 'javascript' and 'JavaScript') in some
-            # cases. The most common instance of this is user
-            # tags, which are coerced to lowercase on save to avoid
-            # the problem, but because there are a large number of
-            # these duplicates already existing, we do a quick filter
-            # here to ensure we don't return a bunch of dupes that
-            # differ only by case.
-            seen = []
             results = []
             for tag in tags:
-                if tag.name.startswith(namespace) and tag.name.lower() not in seen:
-                    seen.append(tag.name.lower())
+                if tag.name.startswith(namespace):
                     results.append(tag)
             return results
 

kuma/static/js/users.js

@@ -87,8 +87,7 @@
     $(document).ready(function(){
 
         // Convert interests text field into a tag-it widget
-        // also lowercase to deal with database weirdness
-        var interests = $('#id_user-interests').val().toLowerCase();
+        var interests = $('#id_user-interests').val();
         $('#id_user-interests').hide()
             .val(interests)
             .after('<ul id="tagit-interests"></ul>')
@@ -108,9 +107,8 @@
         $('#tagit-interests .tagit-new input').attr('placeholder', gettext('New interest...'));
 
         // Convert the expertise text field into tag list
-        // lowercase to deal with database weirdness
         // checkboxes sync'd to interests
-        var expertise = $('#id_user-expertise').val().toLowerCase();
+        var expertise = $('#id_user-expertise').val();
         $('#id_user-expertise').hide()
         .val(expertise)
         .after('<ul id="tags-expertise" class="tags"></ul>');

kuma/users/views.py

@@ -429,7 +429,7 @@ def user_edit(request, username):
             # Update tags from form fields
             for field, tag_ns in field_to_tag_ns:
                 field_value = user_form.cleaned_data.get(field, '')
-                tags = [tag.lower() for tag in parse_tags(field_value)]
+                tags = parse_tags(field_value)
                 new_user.tags.set_ns(tag_ns, *tags)
 
             return redirect(edit_user)