Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Bug 1414107: Remove line_length waffle #4568

Merged
merged 1 commit into from Dec 4, 2017
Merged

Conversation

stephaniehobson
Copy link
Contributor

Can be reviewed now but need to wait until next week to get go-ahead.

(Not actually expecting this will be reviewed until next week ;)

@stephaniehobson stephaniehobson changed the title Bug 1414107: Remove line_length waffle [DO NOT MERGE] Bug 1414107: Remove line_length waffle Nov 23, 2017
@codecov-io
Copy link

Codecov Report

Merging #4568 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4568   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files         262      262           
  Lines       23155    23155           
  Branches     1669     1669           
=======================================
  Hits        22028    22028           
  Misses        909      909           
  Partials      218      218
Impacted Files Coverage Δ
kuma/settings/common.py 91.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f41629...9d5a3ea. Read the comment docs.

@stephaniehobson
Copy link
Contributor Author

Confident we can roll this into production now. Once it's signed off of course.

@jwhitlock
Copy link
Contributor

Does the [DO NOT MERGE] in the title still apply?

@stephaniehobson stephaniehobson changed the title [DO NOT MERGE] Bug 1414107: Remove line_length waffle Bug 1414107: Remove line_length waffle Dec 1, 2017
@stephaniehobson
Copy link
Contributor Author

Oops, no.

@schalkneethling
Copy link

No reference found to any of the following:

wiki-skinny.scss
main-skinny.scss
includes-skinny
components-skinny
line_length

Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a sanity check on a couple of pages locally. All looks good. r+ 🏋️‍♀️ from me

Copy link
Contributor

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice, clean removal 😄 I rebuilt the Docker image, and no missing files when building with hashed asset names.

@jwhitlock jwhitlock merged commit 0dd9a80 into master Dec 4, 2017
@jwhitlock jwhitlock deleted the 1414107-remove-waffle branch December 4, 2017 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants