This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
bug 1461350: Update Middleware tests #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert LocaleURLMiddlware and get_best_language tests to pytest style, and share the get_best_language test cases with the LocaleURLMiddlware tests, since get_best_language won't be needed after the Django 1.11 transition.
Add tests for MDN-specific locale fixes, such as cn → zh-CN, and for legacy URLs that should 404, such as index.php. These were previously tested only in headless tests, but are part of the URL contract.
Test ?lang redirects for the root URL, the English homepage, and when the parameter is the same as the current locale.
Convert the remaining middleware tests (RemoveSlashMiddleware, SetRemoteAddrFromForwardedFor) to pytest.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to update the locale infrastructure, expand tests for middleware and other components, and convert to pytest style:
LocaleURLMiddlewareAccept-Languageheader variations fromget_best_language?langscenariosRemoveSlashMiddleware- Convert tests to pytest. The test cases actually exercise themindtouch_to_kuma_redirectview, and the middleware code never runs. The next PR will update the test cases and fix the functionality.SetRemoteAddrFromForwardedFor- Convert tests to pytest.This was originally part of PR #4766, but has been split out to confirm that tests pass with
LocaleURLMiddlewarebefore replacing it.