This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
bug 1461350: Simplify test client #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the Django-based LocaleMiddleware, all URLs get a locale prefix by default, so the LocalizingClient and the LocalizingMixin no longer needed to ensure locale-prefixed URLs are used in tests.
This functionality was added to the base test client in Django 1.7.
jwhitlock
requested review from
jezdez and
escattone
and removed request for
jezdez
|
Yep I can confirm this was code added to bridge the gap until modern Django is used. |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
LocaleMiddleware, the default is to include the locale prefix in URLs, so theLocalizingMixinandLocalizingClientare no longer needed.The
SessionAwareClientincluded code from Django 1.7, and was probably added when MDN was on Django 1.4 or earlier, and is included in the default 1.8 test client:https://github.com/django/django/blob/6a0dc2176f4ebf907e124d433411e52bba39a28e/django/test/client.py#L411-L426