Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

bug 1462475: add db migration to cleanup after zones #4924

Merged
merged 1 commit into from Aug 7, 2018
Merged

bug 1462475: add db migration to cleanup after zones #4924

merged 1 commit into from Aug 7, 2018

Conversation

escattone
Copy link
Contributor

@escattone escattone commented Aug 7, 2018

This PR should only be merged and deployed after #4923 has been merged and deployed. It is part of the cleanup after the death of zones #4853. It adds the DB migration necessary to remove the wiki_documentzone table and the zone_subnav_local_html field from the wiki_document table.

Copy link
Contributor

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye, zones 💀

@jwhitlock jwhitlock merged commit c504d12 into mdn:master Aug 7, 2018
@jwhitlock
Copy link
Contributor

jwhitlock commented Aug 7, 2018

If you have an existing development environment, you may want to run this migration.

(host) $ make bash
 (web) $ ./manage.py migrate

There is some leftover data after this change. A ContentType was created for DocumentZone, along with some related permissions. To clean these up, use a new command added in Django 1.11

(host) $ make bash
 (web) $ ./manage.py remove_stale_contenttypes

This is worth the Django 1.11 for me, it used to be really hard to get rid of this data.

I'm expecting another migration in the PR for bug 1455348, and then I'll start on a new sample database without zones.

@escattone escattone deleted the zone-db-migration-1462475 branch August 7, 2018 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants