-
Notifications
You must be signed in to change notification settings - Fork 681
Bug 1501282, add BCD survey #5133
Bug 1501282, add BCD survey #5133
Conversation
Thanks Schalk! 👍 As I said in the issue, I would go with "Take the quick survey" (but maybe @atopal or @shilili have another optimized wording). Otherwise, I would go with whatever we usually put in the soapbox. Same for new tab or not. If I remember well, the soapbox had links opened in a new tab. I managed to test this locally and it works fine. When there are multiple compat tables on a page, the survey is only shown for the first table, which I think is good. This screenshot is from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Browser_support_for_JavaScript_APIs. I'm not sure if we actually tested labels and icons for this page, it looks a bit off, because there are a lot less browsers in WebExtension tables. We might want to do something about this. |
Oh wow, I have actually not seen this before :/ I reckon it makes sense to open an issue to look into better spacing for the text labels. |
Do you want a new Bugzilla bug for this? Or an mdn/sprint issue? Or should I comment this issue on https://bugzilla.mozilla.org/show_bug.cgi?id=1438889 ? Or something else? :) (yay processes 😄) |
Kuma still requires a Bugzilla bug so, a new Bugzilla bug assigned to me would be great. If you could also highlight other pages that deviates from the norm, that would be extra bonus points ;p Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected for me. 👍
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this whitespace seems unnecessary
This adds the new survey to the BCD table. This is ready for code review. Still need to confirm the following:
@Elchi3 r?