This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
don't depend on window.ga till it's actually needed #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6066 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 297 297
Lines 25466 25466
Branches 1889 1889
=======================================
Hits 24387 24387
Misses 848 848
Partials 231 231Continue to review full report at Codecov.
|
escattone
approved these changes
Oct 29, 2019
| @@ -4,9 +4,13 @@ import { useContext, useEffect, useState } from 'react'; | |||
|
|
|||
| export type GAFunction = (...any) => void; | |||
|
|
|||
| const noop: GAFunction = () => {}; | |||
| function ga(...args) { | |||
| if (typeof window === 'object' && typeof window.ga === 'function') { | |||
There was a problem hiding this comment.
I'm wondering, if in the future we should consider making this "Ghostery"-proof like we do here in kuma/static/js/analytics.js? Something to think about, but not for this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5986