This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Front-end testing cleanup and improvements #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindy
commented
May 12, 2020
| @@ -121,7 +121,7 @@ module.exports = { | |||
| // setupFiles: [], | |||
|
|
|||
| // The path to a module that runs some code to configure or set up the testing framework before each test | |||
| // setupTestFrameworkScriptFile: null, | |||
There was a problem hiding this comment.
From the Jest docs:
Note: setupTestFrameworkScriptFile is deprecated in favor of setupFilesAfterEnv.
mindy
commented
May 12, 2020
| @@ -55,7 +55,9 @@ export default function Article({ document }: DocumentProps) { | |||
| // This is a one-time effect we need to call the first time an article | |||
| // is rendered, to ensure that interactive examples resize themselves | |||
| // if the browser width changes. | |||
| useEffect(InteractiveExamples.makeResponsive, []); | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
This is to fix an eslint error from react-hooks, it said to make this an inline function.
peterbe
approved these changes
May 12, 2020
peterbe
added
the
merge when green
mindy
commented
May 12, 2020
| } | ||
| }, [props.initialQuery]); | ||
| }, [initialQuery]); |
There was a problem hiding this comment.
Another eslint error fix-- props will change when any props change (in this case there's only one prop right now so it doesn't really matter) so the fix is to destructure props and refer to the specific props inside useEffect.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
eslint-plugin-testing-library(thanks @peterbe for sharing this article!)jest-dombefore test files - I think we use it enough that it makes sense to always have it available.To test:
Run
jest