This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
commented
Feb 13, 2019
ExE-Boss
commented
Mar 6, 2019
ExE-Boss
force-pushed
the
test/fix-windows
branch
3 times, most recently
from
March 19, 2019 14:23
cf21c20
to
d85cc5e
Compare
9 tasks
ExE-Boss
force-pushed
the
test/fix-windows
branch
from
April 18, 2019 21:35
0820246
to
fce55dc
Compare
ExE-Boss
added a commit
to EB-Forks/kumascript
that referenced
this pull request
Aug 31, 2019
* test: Fix `template.test.js` on Windows * test(utils): Fix `lintHTML` on Windows
ExE-Boss
force-pushed
the
test/fix-windows
branch
from
September 1, 2019 05:33
92def39
to
0aafd74
Compare
peterbe
reviewed
Sep 2, 2019
peterbe
suggested changes
Sep 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That hacks/fixes are easy to forget. Can you please transpose your GitHub comments into the code as one-liners.
Co-Authored-By: Peter Bengtsson <mail@peterbe.com>
peterbe
approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
templates
test was failing on Windows due to the usage of\
in file paths, where the test expected/
.review?(@chrisdavidmills, @davidflanagan, @Elchi3, @jwhitlock, @peterbe, @wbamberg)