Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

test: Fix tests on Windows #1057

Merged
merged 6 commits into from
Sep 4, 2019
Merged

test: Fix tests on Windows #1057

merged 6 commits into from
Sep 4, 2019

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jan 30, 2019

The templates test was failing on Windows due to the usage of \ in file paths, where the test expected /.


review?(@chrisdavidmills, @davidflanagan, @Elchi3, @jwhitlock, @peterbe, @wbamberg)

ExE-Boss added a commit to EB-Forks/kumascript that referenced this pull request Aug 31, 2019
* test: Fix `template.test.js` on Windows

* test(utils): Fix `lintHTML` on Windows
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That hacks/fixes are easy to forget. Can you please transpose your GitHub comments into the code as one-liners.

tests/macros/utils.js Show resolved Hide resolved
tests/templates.test.js Show resolved Hide resolved
@peterbe peterbe merged commit 9614304 into mdn:master Sep 4, 2019
@ExE-Boss ExE-Boss deleted the test/fix-windows branch September 4, 2019 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants