This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
refactor(GroupData): Fold “CSSOM View” into “CSS Object Model” #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
Please, don't do this. If the PR is to fold CSSOM View into CSSOM, let it just do that. |
ExE-Boss
force-pushed
the
macros/group-data/fold-cssom-view
branch
from
4462bbf
to
3f82613
Compare
1 task
ExE-Boss
force-pushed
the
macros/group-data/fold-cssom-view
branch
2 times, most recently
from
4462bbf
to
9fc5cc3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this proposal on Discourse for details.
I’ve also added interfaces that were added to the specs since CSSOM Group Data was last updated.(Moved to: #1156)P.S.:
CaretPositionis actually defined in CSSOM View and not in CSSOM.review?(@wbamberg)