This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Use 'mdn' branch when loading data from mdn/data #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to start pushing this out Mon. April 3rd, if the review looks good. |
|
That sounds good. I wasn't able to get a functional local Kuma to test it unfortunately, but I will try again today. |
wbamberg
approved these changes
Mar 30, 2017
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Apr 3, 2017
* mdn/kumascript#134 - LegacyAddonNotice - add zh-CN strings * mdn/kumascript#138 - LearnSidebar - add Intro to CSS Layout link * mdn/kumascript#139 - SpecName, Spec2 - ES6 / ES7 / ESDraft * mdn/kumascript#140 - Spec2 - add pt-PR strings * mdn/kumascript#143 - CSSRef, etc - use mdn branch for live data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems impossible to get #132 reviewed soon. However, we want to move forward with mdn/data#52, so I think we should use a branch for now. I think it would only be necessary to load the branched data for the csssyntax macro, but I think it is safer to have all macros load from this branch.
There are also thoughts around removing the csssyntax macro from MDN (or ideally rewriting it for more user-friendly formal syntax information), but it won't happen any time soon either (1800 pages affected).