bug 1354243: add macro linter (for JSON "macros")

Jenkinsfile

@@ -8,10 +8,11 @@ node {
         }
 
         stage('Test') {
+          sh 'make lint-macros'
           try {
-              sh 'make test VERSION=latest TEST_RUN_ARGS="--reporter=junit --output=junit-results"'
+            sh 'make test VERSION=latest TEST_RUN_ARGS="--reporter=junit --output=junit-results"'
           } finally {
-              junit 'junit-results/*.xml'
+            junit 'junit-results/*.xml'
           }
         }
 
@@ -27,10 +28,11 @@ node {
         }
 
         stage('Test') {
+          sh 'make lint-macros'
           try {
-              sh 'make test TEST_RUN_ARGS="--reporter=junit --output=junit-results"'
+            sh 'make test TEST_RUN_ARGS="--reporter=junit --output=junit-results"'
           } finally {
-              junit 'junit-results/*.xml'
+            junit 'junit-results/*.xml'
           }
         }
 

Makefile

@@ -34,6 +34,8 @@ lint:
 lint-macros:
 	docker run ${DOCKER_RUN_ARGS} ${IMAGE} \
 	    /node_modules/.bin/ejslint "macros/**/*.ejs"
+	docker run ${DOCKER_RUN_ARGS} ${IMAGE} \
+	    /node_modules/.bin/jsonlint-cli "macros/**/*.json"
 
 bash:
 	docker run -it ${DOCKER_RUN_ARGS} ${IMAGE} bash

README.md

@@ -65,7 +65,7 @@ summary:
       login, create a new document that uses your new or modified macro(s), and
       test that it renders correctly.
 
-    * Run the macro linter to check for JavaScript syntax errors:
+    * Run the macro linter to check for syntax errors:
 
           make lint-macros
 
@@ -138,7 +138,8 @@ more before you run your local development version of MDN.
     * `make test`
 * To check your code (using JSHint):
     * `make lint`
-* To check for JavaScript syntax errors within all macros (using ejslint):
+* To check for JavaScript syntax errors within the EJS macros (using `ejslint`)
+  and JSON syntax errors within the JSON data files (using `jsonlint-cli`):
     * `make lint-macros`
 * To run the service:
     * `make run`

macros/L10n-HTML.json

@@ -33,7 +33,7 @@
     },
     "tagOmission": {
         "en-US": "Tag omission",
-        "ca"   : "Omissió de l\'etiqueta",
+        "ca"   : "Omissió de l'etiqueta",
         "de"   : "Tagauslassung",
         "es"   : "Omisión de la etiqueta",
         "fr"   : "Omission de balises",