-
Notifications
You must be signed in to change notification settings - Fork 175
Merge specification status, names and urls into a single source #557
Conversation
We have discussed this in December in Austin and the outcome was that we don't want to make a change to the kumascript macro using this data without writing tests for them before hands. Such tests are a prerequisite before going forward here. |
I see there are already some basic tests for spec2.ejs and SpecName.ejs. Is there a description of what additional tests would be needed to enable such a change? |
I agree with the goal, but I think that
I've gone into more detail at mdn/data#158 (comment). |
I have updated the pull request to keep the data local for now |
The approach looks good to me. I'd appreciate a 👍 from other MDN staffers to the idea. I haven't reviewed the code yet, but I'm willing if we want to go this way. @dontcallmedom - are you comfortable rebasing to resolve conflicts? |
I also have some ideas about how this data could be used if it were extracted. I want to repeat the request for what additional tests we would need. |
See https://github.com/mdn/data commit f887785798be1c896148f8edc1c415aceafa3ae3
See https://github.com/mdn/data commit c7dea7da24f7417420204ce19c2c48c7feb1fc16
Also merge status, names and urls in a single source based on feedback at mdn/data#158 (comment)
819931a
to
5b6de33
Compare
rebased |
I see @Elchi3 gave a 👍 to my comment mdn/data#158 (comment) and touched the bug, let's proceed. @teoli2003, please add any details you can remember about the additional requirements. We have passing test suites for the spec2 and specname macros, so I have more confidence this worked. We should also get an error if the JSON in SpecData.json is ill-formed, so that should help. I'd like:
I'm considering if the alternate keys ("CSS3 2D Transforms" is an older name for "CSS3 Transforms") should be in the JSON, like: {
"CSS3 Transforms": {
"old_keys": ["CSS3 2D Transforms"],
"name": "CSS Transforms Level 1",
"url": "https://drafts.csswg.org/css-transforms/",
"status": "WD"
},
} It depends if we see these alternate keys as an accident of MDN history or a useful long-term feature. I think all those could be done as follow-on PRs, so I'm accepting the PR, and will wait for @Elchi3 or @teoli2003 to merge. |
After thinking about it, the "extra tests" are probably those needed to switch to using the |
The purpose of extracting it is to make it easier to validate and update it - I have a number of ideas and tools that I can apply to this, but it's much easier to apply them if the data is cleanly separated.
See also mdn/data#157