Localization of WebExtensions Sidebar #755
Conversation
|
👋 |
|
@etiennewan ping me whenever you are done :) Thanks for the PR |
SphinxKnight
changed the title
|
@SphinxKnight I'm done translating, I did a quick review to remove or rename some duplicate keys. If some are still there, it's time to find them ! 🙂 |
There was a problem hiding this comment.
This looks great, thank you!
I had a few comments. I'm trusting you and @SphinxKnight that the translations are good :).
macros/AddonSidebar.ejs
Outdated
| @@ -12,145 +12,320 @@ function currentPageIsUnder(root) { | |||
| return "closed"; | |||
| } | |||
|
|
|||
| var text = mdn.localStringMap({ | |||
| 'en-US': { | |||
There was a problem hiding this comment.
We are horribly inconsistent throughout this code in single versus double quotes, but we should at least try to be consistent within each macro.
I think single quotes is better, so would you mind fixing up lines 1-13 of this file to use single quotes?
I see that we also use double quotes for HTML attributes. Perhaps we should leave those ones, that seems to be what we use on MDN.
There was a problem hiding this comment.
Fixed, and I agree, it is better to have consistency within a file.
macros/AddonSidebar.ejs
Outdated
| 'Forums': 'Add-on forums', | ||
| '#Contact_us': 'Contact us' | ||
| }, | ||
| 'fr-FR': { |
There was a problem hiding this comment.
I know almost nothing about the way Kuma handles locales, but I think this needs to be just "fr".
If I try your macro, on, say, "http://llocalhost:8000/fr-FR/docs/Web/CSS", then I get redirected to "http://localhost:8000/fr/docs/Web/CSS" and see the en-US strings (I guess this is used as the fallback.
If I change line 102 to just "fr" then I see the French strings.
macros/AddonSidebar.ejs
Outdated
| 'Forums': 'Forum extensions', | ||
| '#Contact_us': 'Nous contacter' | ||
| } | ||
| }) |
There was a problem hiding this comment.
Let's blame the linter for that 🙂 fixed 👍
There was a problem hiding this comment.
Thanks @etiennewan , this works great.
I'll ask @SphinxKnight for a review, if he's happy with the strings then I'm happy for this to be merged.
|
Fixed some typos |
I only adapted a few strings.
There was a problem hiding this comment.
OK with me regarding the localization. Great job @etiennewan :)
SphinxKnight
changed the title
No description provided.