This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
refactor(macros): Use a more future‑proof method for sidebar slug processing #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
commented
Oct 29, 2018
ExE-Boss
force-pushed
the
macros/mdn-common
branch
5 times, most recently
from
5698f23
to
c21842b
Compare
ExE-Boss
changed the title
trimSlugStart(…) utility method for sidebar macros
ExE-Boss
force-pushed
the
macros/mdn-common
branch
3 times, most recently
from
4c5f685
to
18a4b15
Compare
ExE-Boss
changed the title
ExE-Boss
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of bug 1519579.
This refactors the sidebar slug processing method to avoid using
String.replace(…).A bonus of this is that sidebar macros (
{{APIRef}},{{CSSRef}}, etc.) are supported outside ofWeb/<namespace>, eg.Archive/Web/<namespace>,Mozilla/Gecko/Chrome/<namespace>, etc.Depends on:
review?(@wbamberg)