Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong use of <address> in making-up-a-letter-finished? #2

Closed
hutstep opened this issue Oct 11, 2016 · 1 comment
Closed

Wrong use of <address> in making-up-a-letter-finished? #2

hutstep opened this issue Oct 11, 2016 · 1 comment

Comments

@hutstep
Copy link

hutstep commented Oct 11, 2016

According to the marking guide one should wrap both addresses at the top each in an <address> element.
https://github.com/mdn/learning-area/blob/master/html/introduction-to-html/marking-up-a-letter-finished/marking-guide.md
Isn't that wrong? In MDN it states:
mdn-address
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/address

According to this, wrapping the second address (Miss Eileen Dover) in an <address> element is definitely wrong.
I'm not sure about the first address (Dr. Eleanor Gaye), but I think it's okay, because it's the author of the letter.

@chrisdavidmills
Copy link
Contributor

Only just seen this; my apologies. We've fixed this now.

Zou150 pushed a commit to Zou150/learning-area that referenced this issue Nov 21, 2020
highlight:auto_detect default as false
ajolguin added a commit to ajolguin/js-practice that referenced this issue Jul 8, 2022
alotofuptime added a commit to alotofuptime/learning-area that referenced this issue Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants