Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oojs.html example shows HTML0204 lint warning #595

Closed
TheCodePilot opened this issue Feb 23, 2023 · 5 comments
Closed

oojs.html example shows HTML0204 lint warning #595

TheCodePilot opened this issue Feb 23, 2023 · 5 comments
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@TheCodePilot
Copy link
Contributor

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Basics

What specific section or headline is this issue about?

javascript/oojs/introduction/oojs.html

What information was incorrect, unhelpful, or incomplete?

This ...

<script> </script>

What did you expect to see?

<body>
    <p> ...</p>
    <script>

    </script>
</body>

Do you have any supporting links, references, or citations?

Ich arbeite mit Visual Studio. Wenn ich das Skript:
javascript/oojs/introduction/oojs.html
entsprechend kopiere:
Bekomme ich diesen Hinweis siehe Bild.

Ich bin sehr zufrieden mit Eurer Arbeit und alles andere war auch nie ein
Fehler
Problem wenn ich Code von Euch zum Üben nutzte.

Do you have anything more you want to share?

Ich bitte um Antwort.
Mit freundlichen Grüßen:

MDN metadata

Page report details
@TheCodePilot TheCodePilot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 23, 2023
@dipikabh
Copy link

Hello @TheCodePilot! Welcome to the MDN Web Docs project. 🙌

Could you highlight exactly what section and code you are referring to on this page https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Basics?

You might want to go over our documentation on JavaScript basics to help you get started.

@TheCodePilot
Copy link
Contributor Author

TheCodePilot commented Feb 23, 2023 via email

@bsmth bsmth changed the title HTML0204 oojs.html example shows HTML0204 lint warning Feb 24, 2023
@bsmth bsmth transferred this issue from mdn/content Feb 24, 2023
@bsmth
Copy link
Member

bsmth commented Feb 24, 2023

Hi @TheCodePilot - thanks for raising the issue. I've transferred this over to the learning area repository.

You're right that the <script> element should be inside the <body>, or in the <head>:

<!DOCTYPE html>
<html lang="en-us">
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width" />
    <title>Object-oriented JavaScript example</title>

    <script></script>
  </head>

  <body>
    <p>
      This example requires you to enter commands in your browser's JavaScript
      console (see
      <a
        href="https://developer.mozilla.org/en-US/docs/Learn/Common_questions/What_are_browser_developer_tools"
        >What are browser developer tools</a
      >
      for more information).
    </p>
  </body>
</html>

Would you like to open a pull request to fix it? You can get started here on GitHub directly if you like:

Screenshot 2023-02-24 at 10 31 15 AM

@TheCodePilot
Copy link
Contributor Author

TheCodePilot commented Feb 24, 2023 via email

@bsmth
Copy link
Member

bsmth commented Feb 24, 2023

Well done on your contribution and welcome! 🎉

I'm going to close the issue as fixed in #596

@bsmth bsmth closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

3 participants