Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Fix linter errors in current short descriptions #18

Merged
merged 2 commits into from Apr 6, 2019

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented Mar 27, 2019

This PR fixes align-content's linter errors, thus getting all of npm test to pass. This is a prerequisite to using Travis on this repo and a convenience for scraping more short descriptions.

@ddbeck ddbeck added the bug Something isn't working label Mar 27, 2019
@ddbeck ddbeck requested a review from wbamberg March 27, 2019 13:12
@@ -2,7 +2,7 @@
"css": {
"properties": {
"align-content": {
"__short_description": "The <a href='https://developer.mozilla.org/docs/Web/CSS'>CSS</a> <strong><code>align-content</code></strong> property sets how the browser distributes space between and around content items along the cross-axis of a <a href='https://developer.mozilla.org/docs/Web/CSS/CSS_Flexible_Box_Layout'>flexbox</a> container, and the main-axis of a grid container."
"__short_description": "The <a href='https://developer.mozilla.org/docs/Web/CSS'>CSS</a> <strong><code>align-content</code></strong> property sets the distribution of space around content items of a <a href='https://developer.mozilla.org/docs/Web/CSS/CSS_Flexible_Box_Layout'>flexbox</a> or <a href='https://developer.mozilla.org/docs/Web/CSS/CSS_Grid_Layout'>grid</a> container. It applies to a flexbox's cross-axis or a grid's tracks."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong but I'm not sure "grid's tracks" is correct - tracks in grid go in both directions. Perhaps you want "block axis"? (https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Box_Alignment_in_CSS_Grid_Layout#The_two_axes_of_a_grid_layout)

Also I think in "around and between", the " and between" part is important.

Do you like: "The CSS align-content property sets the distribution of space between and around content items along the cross-axis of a flexbox or the block axis of a grid."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood how it worked with grid. And I liked your suggestion, but it didn't quite hit the first-sentence-length requirement. I adjusted it a little and hopefully this new one works for you (also updated on the wiki)

Copy link

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thank you @ddbeck !

@wbamberg wbamberg merged commit a7c5934 into mdn:master Apr 6, 2019
@ddbeck ddbeck deleted the fix-linter-errors branch April 7, 2019 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants