Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Update Code of Conduct text #20

Merged
merged 1 commit into from Apr 11, 2019
Merged

Update Code of Conduct text #20

merged 1 commit into from Apr 11, 2019

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented Apr 9, 2019

Fixes #19.

@ddbeck ddbeck requested a review from wbamberg April 9, 2019 13:00
Copy link

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @ddbeck !

When I updated the CoC text for some repos, e.g. mdn/data#363, I used the exact text they linked, including the trailing spaces and comment, because I wasn't sure how clever the bot would be.

I'm tempted to suggest doing the same here, except that (1) it will break linters and (2) there's already a PR filed to fix the whitespace. So maybe this is a better approach after all. idk.

@wbamberg wbamberg merged commit 05e33ed into mdn:master Apr 11, 2019
@ddbeck ddbeck deleted the fix-coc branch April 11, 2019 19:14
@ddbeck
Copy link
Contributor Author

ddbeck commented Apr 11, 2019

I figured since it said there was optional text it wouldn't be risky to change it a little. I guess we'll find out. 🤷‍♂️

@wbamberg
Copy link

I also asked in #mdndev and got a useful answer: https://mozilla.logbot.info/mdndev/20190411

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants