-
Notifications
You must be signed in to change notification settings - Fork 144
Refactor animation and transition event docs #1056
Comments
@estelle or @a2sheppy or @irenesmith , would one of you mind reviewing these pages please? |
I changed the example to a transform for best practice reasons: it's best to avoid animating / transitioning properties that cause a reflow. I added some tags. And on iterationevent, i added that it doesn't happen at the same time as animationend |
For transitions, i added what happens when transitionstart and run are at the same time, or if a delay is negative (they're at the same time. I extended your example and added the comparison b/t transitioncancel and transitionend. (if you cancel, does it end?). I did this only for the window events. Did you want to check it out and see if we should add it to document transition events, etc.? |
Thanks for the updates to the examples. I think content like this:
...is super-helpful. Personally I think it would be better to have it at the start (say, immediately after, or before, the blue box) rather than in with the examples. But I don't feel terribly strongly about this.
What if we just add it to the HTMLElement version, then link from the others to that page, since that's the "event target"? |
Added ontransitionstart and ontransitionrun to https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers. Not 100% sure i should have. Also added type of transitionEvent to https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent |
Thanks for all your work on this @estelle ! I was thinking about a good wording for this, what do you think about:
(for example, for the Window: transitionstart page, replacing the para immediately after the blue box?) I like making an explicit reference to bubbling here. |
I've made sure only the HTMLElement version has the live example, and added links from the Window and Document versions to the HTMLElement page. So I'm calling this one closed. |
This is a work item for #685.
Pages:
The text was updated successfully, but these errors were encountered: