Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Update required and optional sections in HTML recipe #74

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented Jul 23, 2019

This PR implements the recipe changes discussed in #55.

One area of uncertainty here is the order of the styling with CSS section. This is a newly defined section and I couldn't find an example of one of these in the wild. My ordering is basically a guess.

@wbamberg
Copy link

Thanks @ddbeck ! I think we also decided to remove usage_notes and fold it into overview (#55 (comment)).

On order, perhaps it would be best to have all the named sections (except see_also), then all the custom sections?

Like:

related_content: /content/related_content/html.yaml
body:
- prose.short_description
- meta.interactive_example?
- prose.overview
- prose.attributes_text?
- meta.attributes
- prose.styling?
- prose.accessibility_concerns?
- prose.*
- meta.examples
- meta.info_box:
    - meta.api
    - meta.permitted_aria_roles
    - meta.tag_omission
- meta.browser_compatibility
- prose.see_also

...it just seems like a simpler rule that way.

@ddbeck
Copy link
Contributor Author

ddbeck commented Jul 24, 2019

Thanks, @wbamberg! Done.

Copy link

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddbeck !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants