Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove ARIARole macro #11185

Closed
7 tasks done
SphinxKnight opened this issue Jan 21, 2023 · 1 comment · Fixed by #11342
Closed
7 tasks done

Chore: remove ARIARole macro #11185

SphinxKnight opened this issue Jan 21, 2023 · 1 comment · Fixed by #11342
Milestone
Macros removal

Comments

@SphinxKnight
Copy link
Member

SphinxKnight commented Jan 21, 2023 •
edited by queengooborg
Loading

Per https://github.com/orgs/mdn/discussions/263#discussioncomment-4738283
@SphinxKnight SphinxKnight added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Jan 21, 2023
@SphinxKnight SphinxKnight added this to the Macros removal milestone Jan 21, 2023
@SphinxKnight SphinxKnight changed the title Chore: remove ARIARoles macro Chore: remove ARIARole macro Jan 21, 2023
@yin1999
Copy link
Member

yin1999 commented Jan 21, 2023 •
edited
Loading

I think we can use regexp to replace those: \{\{\s*ARIARole\s*\(\s*['"]([^'"]+)['"]\s*\)\s*\}\}, replaced with <a href="/<locale>/docs/Web/Accessibility/ARIA/Roles/$1_role"><code>$1</code></a> (note to replace <locale> as the specified one)

Just note some usage in pure markdown (most of them are in html <table>).

@yin1999 yin1999 mentioned this issue Jan 21, 2023
Merged
@hochan222 hochan222 mentioned this issue Jan 21, 2023
Merged
@hochan222 hochan222 removed the l10n-ko Issues related to Korean content. label Jan 21, 2023
@yin1999 yin1999 removed the l10n-zh Issues related to Chinese content. label Jan 22, 2023
@rwxdan rwxdan mentioned this issue Jan 22, 2023
Merged
@yin1999 yin1999 removed the l10n-es Issues related to Spanish content. label Jan 25, 2023
This was referenced Feb 1, 2023
Merged
Merged
Merged
Merged
@yin1999 yin1999 removed l10n-fr Issues related to French content. l10n-pt-br Issues related to Brazilian Portuguese labels Feb 1, 2023
@mfuji09 mfuji09 removed the l10n-ja Issues related to Japanese content. label Feb 5, 2023
@yin1999 yin1999 linked a pull request Feb 6, 2023 that will close this issue
ru: Remove {{ARIARole}} macro #11342
Merged
@queengooborg queengooborg removed the l10n-ru Issues related to Russian content. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Macros removal
Development

Successfully merging a pull request may close this issue.

ru: Remove {{ARIARole}} macro mdn/translated-content
5 participants
@SphinxKnight @queengooborg @mfuji09 @yin1999 @hochan222